refactor: cleanup mix credo issues

lib/components_elixir/inventory/component.ex

@@ -70,17 +70,21 @@ defmodule ComponentsElixir.Inventory.Component do
 
   defp validate_url(changeset, field) do
     validate_change(changeset, field, fn ^field, url ->
-      if url && url != "" do
-        case URI.parse(url) do
-          %URI{scheme: scheme} when scheme in ["http", "https"] -> []
-          _ -> [{field, "must be a valid URL"}]
-        end
-      else
-        []
+      cond do
+        is_nil(url) or url == "" -> []
+        valid_url?(url) -> []
+        true -> [{field, "must be a valid URL"}]
       end
     end)
   end
 
+  defp valid_url?(url) do
+    case URI.parse(url) do
+      %URI{scheme: scheme} when scheme in ["http", "https"] -> true
+      _ -> false
+    end
+  end
+
   @doc """
   Returns true if the component has an image.
   """

lib/components_elixir/inventory/hierarchical.ex

@@ -95,7 +95,7 @@ defmodule ComponentsElixir.Inventory.Hierarchical do
       # Remove self-reference
       entity_id == editing_entity_id ||
       # Remove descendants (they would create a cycle)
-      is_descendant?(entities, entity_id, editing_entity_id, parent_id_accessor_fn)
+      descendant?(entities, entity_id, editing_entity_id, parent_id_accessor_fn)
     end)
   end
 
@@ -103,16 +103,16 @@ defmodule ComponentsElixir.Inventory.Hierarchical do
   Checks if an entity is a descendant of an ancestor entity.
   Used for cycle detection in parent selection.
   """
-  def is_descendant?(entities, descendant_id, ancestor_id, parent_id_accessor_fn) do
+  def descendant?(entities, descendant_id, ancestor_id, parent_id_accessor_fn) do
     descendant = Enum.find(entities, fn e -> e.id == descendant_id end)
 
     case descendant do
       nil -> false
-      entity -> is_descendant_recursive(entities, entity, ancestor_id, parent_id_accessor_fn)
+      entity -> descendant_recursive?(entities, entity, ancestor_id, parent_id_accessor_fn)
     end
   end
 
-  defp is_descendant_recursive(entities, entity, ancestor_id, parent_id_accessor_fn) do
+  defp descendant_recursive?(entities, entity, ancestor_id, parent_id_accessor_fn) do
     case parent_id_accessor_fn.(entity) do
       nil -> false
       ^ancestor_id -> true
@@ -120,7 +120,7 @@ defmodule ComponentsElixir.Inventory.Hierarchical do
         parent = Enum.find(entities, fn e -> e.id == parent_id end)
         case parent do
           nil -> false
-          parent_entity -> is_descendant_recursive(entities, parent_entity, ancestor_id, parent_id_accessor_fn)
+          parent_entity -> descendant_recursive?(entities, parent_entity, ancestor_id, parent_id_accessor_fn)
         end
     end
   end